Skip to content

Conversation

@vitro-mod
Copy link
Contributor

@vitro-mod vitro-mod commented May 9, 2025

Fixed #31073

Description

HemisphereLightNode uses normalView which causes unwanted color drift when camera angle changes.

This PR changes normalView to normalWorld in light calculation

@github-actions
Copy link

github-actions bot commented May 9, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.29
78.32
336.29
78.32
+0 B
+0 B
WebGPU 548.37
152.05
548.37
152.05
+0 B
+0 B
WebGPU Nodes 547.72
151.9
547.72
151.9
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 466.23
112.58
466.23
112.58
+0 B
+0 B
WebGPU 623.15
168.75
623.15
168.75
+0 B
-1 B
WebGPU Nodes 578.02
158.03
578.02
158.03
+0 B
+0 B

@Mugen87 Mugen87 added this to the r177 milestone May 9, 2025
@Mugen87 Mugen87 changed the title HemisphereLightNode: changed normalView to normalWorld HemisphereLightNode: Changed normalView to normalWorld. May 9, 2025
@Mugen87 Mugen87 merged commit 11ff559 into mrdoob:dev May 9, 2025
12 checks passed
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HemisphereLightNode uses view normals instead of world

2 participants