Skip to content

Add damp accessor to WebGL AfterimagePass class #31035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mugen87 merged 3 commits into from
May 4, 2025
Merged

Add damp accessor to WebGL AfterimagePass class #31035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
797f1f2
Added damp accessor with clamping to WebGL AfterimagePass
neilrackett May 2, 2025
5eda8f1
Updated Afterimage example GUI
neilrackett May 2, 2025
03f74a4
Removed damp clamp and setter JSDocs, tweak getter JSDocs to include …
neilrackett May 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion examples/jsm/postprocessing/AfterimagePass.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class AfterimagePass extends Pass {
*/
this.uniforms = UniformsUtils.clone( AfterimageShader.uniforms );

this.uniforms[ 'damp' ].value = damp;
this.damp = damp;

/**
* The composition material.
Expand Down Expand Up @@ -89,6 +89,23 @@ class AfterimagePass extends Pass {

}

/**
* The damping intensity, from 0.0 to 1.0. A higher value means a stronger after image effect.
*
* @type {number}
*/
get damp() {

return this.uniforms[ 'damp' ].value;

}

set damp( value ) {

this.uniforms[ 'damp' ].value = value;

}

/**
* Performs the after image pass.
*
Expand Down
2 changes: 1 addition & 1 deletion examples/webgl_postprocessing_afterimage.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
window.addEventListener( 'resize', onWindowResize );

const gui = new GUI( { title: 'Damp setting' } );
gui.add( afterimagePass.uniforms[ 'damp' ], 'value', 0, 1 ).step( 0.001 );
gui.add( afterimagePass, 'damp', 0, 1 ).step( 0.001 );
gui.add( params, 'enable' );

}
Expand Down