Add damp accessor to WebGL AfterimagePass class #31035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
reviewed
May 3, 2025
Mugen87
reviewed
May 3, 2025
Contributor
Author
|
Thanks for the feedback: done and done, and will keep them in mind for future PRs. |
neilrackett
changed the title
Mugen87
approved these changes
May 4, 2025
This was referenced May 21, 2025
RuthySheffi
pushed a commit
to RuthySheffi/three.js
that referenced
this pull request
Jun 5, 2025
* Added damp accessor with clamping to WebGL AfterimagePass * Updated Afterimage example GUI * Removed damp clamp and setter JSDocs, tweak getter JSDocs to include range
RuthySheffi
pushed a commit
to RuthySheffi/three.js
that referenced
this pull request
Jun 5, 2025
* Added damp accessor with clamping to WebGL AfterimagePass * Updated Afterimage example GUI * Removed damp clamp and setter JSDocs, tweak getter JSDocs to include range
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a
dampproperty to the WebGLAfterimagePassclass toadd clamping,avoid the need to set uniforms directly and bring it into line with the TSL version.Code style is consistent with the existing codebase and this change has been applied to the
webgl_postprocessing_afterimageexample, which has been tested as working.