Skip to content

Conversation

@Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Dec 19, 2024

Related issue: #30111

Description

This makes sure the backgroundNode and environmentNode are treated a bit more strictly than before since they only allow node input now. So something like below has no effect anymore:

scene.backgroundNode = new THREE.Color( 0x222222 );

It must be:

scene.backgroundNode = color( 0x222222 );

or

scene.background = new THREE.Color( 0x222222 );

@github-actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.4
79.05
339.4
79.05
+0 B
+0 B
WebGPU 486.48
134.97
486.67
135.01
+183 B
+39 B
WebGPU Nodes 485.95
134.87
486.13
134.91
+183 B
+36 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.3
112.11
465.3
112.11
+0 B
+0 B
WebGPU 555.58
150.43
555.76
150.47
+183 B
+40 B
WebGPU Nodes 511.65
140.19
511.83
140.23
+183 B
+40 B

@Mugen87 Mugen87 changed the title Nodes: Ensure getBackgroundNode() and getEnvironmentNode() only returns nodes. Nodes: Ensure getBackgroundNode() and getEnvironmentNode() only return nodes. Dec 19, 2024
@sunag sunag added this to the r172 milestone Dec 19, 2024
@sunag sunag merged commit b1567a0 into mrdoob:dev Dec 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants