Skip to content

VTKLoader: Fix parsing of VTP data with multiple components. #23684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 9, 2022
Merged

VTKLoader: Fix parsing of VTP data with multiple components. #23684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7fb34ab
Fix parsing of VTP data with multiple components
Mar 9, 2022
f388d75
Update VTKLoader.js
Mugen87 Mar 9, 2022
982142a
Update VTKLoader.js
Mugen87 Mar 9, 2022
f462f8b
Update VTKLoader.js
mrdoob Mar 9, 2022
0c1d7f3
Update VTKLoader.js
mrdoob Mar 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion examples/js/loaders/VTKLoader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,8 +688,9 @@
// The [DATA] portion stores contiguously every block appended together. The offset from the beginning of the data section to the beginning of a block is
// computed by summing the compressed block sizes from preceding blocks according to the header.

const textNode = ele[ '#text' ];
const rawData = Array.isArray( textNode ) ? textNode[ 0 ] : textNode;

const rawData = ele[ '#text' ];
const byteData = Base64toByteArray( rawData );
let blocks = byteData[ 0 ];

Expand Down
3 changes: 2 additions & 1 deletion examples/jsm/loaders/VTKLoader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -736,7 +736,8 @@ class VTKLoader extends Loader {
// The [DATA] portion stores contiguously every block appended together. The offset from the beginning of the data section to the beginning of a block is
// computed by summing the compressed block sizes from preceding blocks according to the header.

const rawData = ele[ '#text' ];
const textNode = ele[ '#text' ];
const rawData = Array.isArray( textNode ) ? textNode[ 0 ] : textNode;

const byteData = Base64toByteArray( rawData );

Expand Down