VTKLoader: Fix parsing of VTP data with multiple components. #23684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix parsing of VTP, currently failing when a data item contains multiple components. In that case, ele['#text'] is not the compressed data but an array of 1 element (this data). This makes the parsing fail as Base64toByteArray expects a string. Use the array's content for parsing.
Mugen87
changed the title
|
Thanks! |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
…23684) * Fix parsing of VTP data with multiple components Fix parsing of VTP, currently failing when a data item contains multiple components. In that case, ele['#text'] is not the compressed data but an array of 1 element (this data). This makes the parsing fail as Base64toByteArray expects a string. Use the array's content for parsing. * Update VTKLoader.js * Update VTKLoader.js * Update VTKLoader.js * Update VTKLoader.js Co-authored-by: Michael Herzog <[email protected]> Co-authored-by: mrdoob <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix parsing of VTP, currently failing when a data item contains multiple
components.
In that case, ele['#text'] is not the compressed data but
an array of 1 element (this data). This makes the parsing fail as Base64toByteArray expects a string.
Use the array's content for parsing.
Fixed #23683