Skip to content

EXRLoader: handle unsupported BigInt Safari mobile #23267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 18, 2022
Merged

EXRLoader: handle unsupported BigInt Safari mobile #23267

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
74d86a6
EXRLoader: handle unsupported BigInt Safari mobile
sciecode Jan 18, 2022
599f2dc
Code formatting...
sciecode Jan 18, 2022
827e65c
Doobers styling
sciecode Jan 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions examples/jsm/loaders/EXRLoader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1756,9 +1756,18 @@ class EXRLoader extends DataTextureLoader {

}

function parseInt64( dataView, offset ) {
const parseInt64 = function( dataView, offset ) {

var int = Number( dataView.getBigInt64( offset.value, true ) );
let int;

if ( DataView.prototype.getBigInt64 ) {

int = Number( dataView.getBigInt64( offset.value, true ) );

} else {

int = dataView.getUint32( offset.value + 4, true ) + Number( dataView.getUint32( offset.value, true ) << 32 );
}

offset.value += ULONG_SIZE;

Expand Down Expand Up @@ -2003,10 +2012,10 @@ class EXRLoader extends DataTextureLoader {
const spec = dataView.getUint8( 5, true ); // fullMask

EXRHeader.spec = {
singleTile: !! ( spec & 1 ),
longName: !! ( spec & 2 ),
deepFormat: !! ( spec & 4 ),
multiPart: !! ( spec & 8 ),
singleTile: !! ( spec & 2 ),
longName: !! ( spec & 4 ),
deepFormat: !! ( spec & 8 ),
multiPart: !! ( spec & 16 ),
};

// start of header
Expand Down