EXRLoader: handle unsupported BigInt Safari mobile #23267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guilherme Avila <[email protected]>
Signed-off-by: Guilherme Avila <[email protected]>
mrdoob
reviewed
Jan 18, 2022
Signed-off-by: Guilherme Avila <[email protected]>
|
Seems like this PR introduced a LGTM issue: |
|
Yeah. Right-side shift is supposed to be a BigInt shift operation, not integer. I'm working on a PR to implement Tiled EXR ( data generated mipmaps ), is ok if I ship the fix alongside that? I don't actually expect this to affect many people, as we only start needing the upper 32b if the users are loading 8K+ res images. |
Sounds good 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #23260
Utilizes alternative Int64 handling when
DataView.prototype.getBigInt64isn't available.Also fixes a small mistake on my part on retrieving specification flags information, it should be properly reflecting the actual file information now.
DWAA Example - @inear please validate the example loads correctly.