Material: Remove skinning. #21788
Merged
Material: Remove skinning. #21788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sweet! So much red! 😀 |
|
Thanks! |
|
Oh, cool. Will old applications/configuration files that have |
|
It is just deprecated. |
|
but |
Yes. It's not possible to retain this flexibility. However, the user should achieve the same result by just creating an instance of |
|
The last comment on #19912 (comment) ties the failure with Does this change also fix that? |
|
Yes, I think so. |
2 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #20318.
Fixed #19912.
Description
This PR changes how skinning in
three.jsworks. Similar toInstancedMeshwhich enables instanced rendering,SkinnedMeshenables skinning. A separate material property is not necessary anymore. This simplifies the code and also fixes conceptual issues in context of override materials and post processing.More details in #18533 (comment).