Converted TessellateModifier to recursive and made similar to SubdivisionModifier

[arodic]

Currently TessellateModifier is not recursive and requires manual invocation of the modify( geometry ) multiple times like in the example here.

The problem with this is that you can't know when the maxEdgeLength parameter is satisfied and the tessellation is complete. So you have to guess how many iterations you need. In the example 6 seems to do the job, in some other cases any number of iterations between 0 .. n is needed.

This change contains the following:

• Adds internal while ( ! finalized ) tessellation loop that runs until no edge with length > maxEdgeLength exists.
• Instead of mutating geometry from modify( geometry ) argument, it returns new geometry (same as SubdivideModifier).

It also contains a minor change affecting both TessellateModifier and SubdivideModifier:

• Output geometry is same type as input geometry (Geometry vs BufferGeometry)
• Geometry.mergeVertices( precisionPoints ) now accepts optional precisionPoints argument.
• Increased vertex merging precision to geometry.mergeVertices( 6 ); to avoid collapsing small triangles.

Questions:

• Should precisionPoints for vertex merging also be a property of TessellateModifier and `SubdivideModifier?

[arodic]

@mrdoob I also added maxFaces parameter as another way to limit number of faces more explicitly.

So constructor look like this now: new TessellateModifier( maxEdgeLength, maxIterations, maxFaces ) with all arguments being optional. It makes me wonder if these should be an object instead or perhaps arguments to modify() function?

Also, linting rules did not allow me to define constructor arguments as optional with default values in d.ts file. I tried this:

constructor( maxEdgeLength?: number = 0.1, maxIterations?: number = 6, maxFaces?: number = 100000 );

And I got error:

Error: src/core/Geometry.d.ts(248,17): error TS1015: Parameter cannot have question mark and initializer.
Error: src/core/Geometry.d.ts(248,17): error TS2371: A parameter initializer is only allowed in a function or constructor implementation.

Is this TS linting rule intended?

[gkjohnson]

Is this TS linting rule intended?

As far as I know you can't set default function parameters in d.ts files :(

[arodic]

As far as I know you can't set default function parameters in d.ts files :(

Yeah, I'm still learning about TS. It turns out you can set default values in the constructor but cannot make arguments optional and initialized at the same time. That kinda makes sense since it would be redundant.

Anyway, the lint error is fixed. TessellateModifier is recursive so you dont have to manually repeat the modify() function. And last but not least, you can increase maxIterations and maxFaces if you dont care about computation time.

[mrdoob]

@arodic any chance you could resolve the conflicts?

[arodic]

I'll update this PR asap.

[arodic]

Conflicts resolved. Ready to merge.

[mrdoob]

How about maxFaces = Infinity?

[arodic]

Done.

[mrdoob]

Thanks!