Skip to content

Commit f4b504f

Browse files
authored
Merge pull request #20430 from io-gui/recursive-tesselation
Converted TessellateModifier to recursive and made similar to SubdivisionModifier
2 parents 6e7f347 + 4270fc6 commit f4b504f

File tree

9 files changed

+381
-280
lines changed

9 files changed

+381
-280
lines changed

examples/js/modifiers/SubdivisionModifier.js

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,9 @@ THREE.SubdivisionModifier = function ( subdivisions ) {
2020
// Applies the "modify" pattern
2121
THREE.SubdivisionModifier.prototype.modify = function ( geometry ) {
2222

23-
if ( geometry.isBufferGeometry ) {
23+
var isBufferGeometry = geometry.isBufferGeometry;
24+
25+
if ( isBufferGeometry ) {
2426

2527
geometry = new THREE.Geometry().fromBufferGeometry( geometry );
2628

@@ -30,7 +32,7 @@ THREE.SubdivisionModifier.prototype.modify = function ( geometry ) {
3032

3133
}
3234

33-
geometry.mergeVertices();
35+
geometry.mergeVertices( 6 );
3436

3537
var repeats = this.subdivisions;
3638

@@ -43,7 +45,15 @@ THREE.SubdivisionModifier.prototype.modify = function ( geometry ) {
4345
geometry.computeFaceNormals();
4446
geometry.computeVertexNormals();
4547

46-
return geometry;
48+
if ( isBufferGeometry ) {
49+
50+
return new THREE.BufferGeometry().fromGeometry( geometry );
51+
52+
} else {
53+
54+
return geometry;
55+
56+
}
4757

4858
};
4959

0 commit comments

Comments
 (0)