Editor: Move to ES6 modules (2nd attempt). #18201
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the editor to ES6 modules. I've found now a way in order to not rely on
build/three.jsanymore which was a blocker for the previous PR (see #16968).@mrdoob Please review how
app.jswas changed. The problem is that the file is used in the editor (as part of the player) and in published projects. Hence it's not possible to importthree.modules.jswithin the file since the path depends on the use case.THREEis now injected vianew APP.Player( THREE );. It's also necessary to defineTHREEinto the global namespace so the editor scripts are able to run.We might want to merge the PR at the beginning of the next dev cycle since this needs some careful testing^^.