Editor : Basic Material browser implementation

[sdinesh86]

(...) #17495

Cleaned up the code and now making specific PR for material browser

[Mugen87]

There are some minor style issues in your code. I suggest you setup your editor in a way so it automatically respect the project's style guide (defined in mdcs).

You can then automatically fix such issues and produce outputs like:

if ( materials[ i ].id === id ) {

    material = materials[ i ];
    break;

}

[sdinesh86]

Will do it,

Will need some getting used to, to these linters :)

[mrdoob]

I think this is good enough. I'll clean things after merging 👌

[mrdoob]

Thanks!

[mrdoob]

@sdinesh86 FYI 8633560 c26e154 5adaa9d a9d50e7

[mrdoob]

@sdinesh86 Also 3b9016b 294246b b8903a4

[sdinesh86]

@mrdoob THANKS for the cleanup and update !!!

I will keep a note of these things in next PR

[Mugen87]

While testing the ES6 module code, I've encountered something I'm not sure about. It's possible to reproduce in prod:

• Go to https://threejs.org/editor/
• Add a Box
• Go to "PROJECT" tab. You see the instance of MeshStandardMaterial in the materials section.
• Go back to "SCENE" and change the box's material to MeshBasicMaterial
• Go to "PROJECT" tab. The material browser shows MeshStandardMaterial but not the newly added MeshBasicMaterial

Is this a bug or am I doing something wrong?

Besides, when using the dark mode CSS, it's really hard to recognize the active list element:

The bottom list element is actually active^^.

[mrdoob]

Is this a bug or am I doing something wrong?

It is definitely a bug. We're probably not dispatching a signal when changing the material.

[Mugen87]

I've tried to fix it via e66bcfe in #18201.