WebGLRenderer: Check if uniforms exist #18175
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR checks if
material uniformstogether withmaterial propertiesin case this logic is broken throughNodeMaterial. This is a serious integration part of NodeMaterial in the core, until now seems the best approach for this.This consists of no case conflicts if the properties of natives materials like
MeshStandardMaterialuse thepropertycolorwith aNodevalue instead ofColor.This PR is entirely linked with this approach ( #18162 ):