Skip to content

Conversation

@sunag
Copy link
Collaborator

@sunag sunag commented Dec 4, 2019

Fix possible changes in material after onBeforeCompile

  • material.side
  • material.blending
  • material.polygonOffset

This not fix completely this issue ( #18038 ) but is a step forward.

@Mugen87 Mugen87 added this to the r112 milestone Dec 4, 2019
@Mugen87 Mugen87 changed the title fix setMaterial() after onBeforeCompile() WebGLRenderer: Call WebGLState.setMaterial() after onBeforeCompile() was executed. Dec 4, 2019
@mrdoob mrdoob merged commit 9f63cb1 into mrdoob:dev Dec 4, 2019
@mrdoob
Copy link
Owner

mrdoob commented Dec 4, 2019

Thanks!

@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 9, 2019

@sunag I'm not sure but could this change broke webgl_materials_nodes?

https://raw.githack.com/mrdoob/three.js/dev/examples/webgl_materials_nodes.html

@sunag
Copy link
Collaborator Author

sunag commented Dec 9, 2019

This broken is related with this

} else if ( material.envMap ) {
refreshUniformsCommon( m_uniforms, material );

This PR: ( #18068 ) could fix but we can find other ways...

Is possible see other NodeMaterial examples using ?e=subexample that does not use material.envMap property. https://raw.githack.com/mrdoob/three.js/dev/examples/webgl_materials_nodes.html?e=standard

@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 9, 2019

It would be good to know which PR has broken NodeMaterial. I think this should be fixed independently of #18068. I've encountered this problem today when implementing the gammaInput change.

@sunag sunag deleted the dev-fix-transparent branch December 9, 2019 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants