Merge pull request #18100 from Mugen87/dev29

mrdoob · web-flow · commit 8ab8f0992103 · 2019-12-07T11:59:11.000-08:00
Clean up lgtm alerts.
diff --git a/examples/webgl_buffergeometry_instancing_interleaved.html b/examples/webgl_buffergeometry_instancing_interleaved.html
@@ -33,7 +33,6 @@
 
 		var container, stats;
 		var camera, scene, renderer, mesh;
-		var offsetAttribute, orientationAttribute;
 
 		var instances = 5000;
 		var lastTime = 0;
diff --git a/examples/webgl_furnace_test.html b/examples/webgl_furnace_test.html
@@ -5,15 +5,6 @@
 		<meta charset="utf-8">
 		<meta name="viewport" content="width=device-width, user-scalable=no, minimum-scale=1.0, maximum-scale=1.0">
 		<link type="text/css" rel="stylesheet" href="main.css">
-		<style>
-			body {
-				color: #444;
-			}
-			a {
-				color: #44f;
-			}
-		</style>
-
 	</head>
 	<body>
 
@@ -30,8 +21,7 @@
 
 			import { PMREMGenerator } from './jsm/pmrem/PMREMGenerator.js';
 
-			var scene, camera, renderer, envMap, radianceMap;
-			var right = 8;
+			var scene, camera, renderer, radianceMap;
 
 			function init() {
 
diff --git a/examples/webgl_materials_envmaps_exr.html b/examples/webgl_materials_envmaps_exr.html
@@ -77,20 +77,13 @@
 
 					pmremGenerator.dispose();
 
-				}
+				};
 
 				new EXRLoader()
 					.setDataType( THREE.FloatType )
 					.load( 'textures/piz_compressed.exr', function ( texture ) {
 
-						var options = {
-							generateMipmaps: false,
-							minFilter: THREE.LinearFilter,
-							magFilter: THREE.LinearFilter
-						};
-
 						exrCubeRenderTarget = pmremGenerator.fromEquirectangular( texture );
-
 						exrBackground = exrCubeRenderTarget.texture;
 
 						texture.dispose();
diff --git a/examples/webgl_materials_nodes.html b/examples/webgl_materials_nodes.html
@@ -69,7 +69,7 @@
 
 			}
 
-			var premTexture, pmremCube, pmremGenerator, premSize = 1024;
+			var premTexture, pmremCube;
 
 			function updatePREM( textureCube ) {
 
diff --git a/examples/webgl_materials_variations_physical.html b/examples/webgl_materials_variations_physical.html
@@ -45,16 +45,6 @@
 
 				//
 
-				var genCubeUrls = function ( prefix, postfix ) {
-
-					return [
-						prefix + 'px' + postfix, prefix + 'nx' + postfix,
-						prefix + 'py' + postfix, prefix + 'ny' + postfix,
-						prefix + 'pz' + postfix, prefix + 'nz' + postfix
-					];
-
-				};
-
 				scene = new THREE.Scene();
 
 				var hdrCubeRenderTarget = null;
diff --git a/src/renderers/WebGLRenderer.js b/src/renderers/WebGLRenderer.js
@@ -782,17 +782,7 @@ function WebGLRenderer( parameters ) {
 
 		//
 
-		var dataCount = Infinity;
-
-		if ( index !== null ) {
-
-			dataCount = index.count;
-
-		} else if ( position !== undefined ) {
-
-			dataCount = position.count;
-
-		}
+		var dataCount = ( index !== null ) ? index.count : position.count;
 
 		var rangeStart = geometry.drawRange.start * rangeFactor;
 		var rangeCount = geometry.drawRange.count * rangeFactor;

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@`
`69`	`69`
`70`	`70`	`}`
`71`	`71`
`72`		`- var premTexture, pmremCube, pmremGenerator, premSize = 1024;`
	`72`	`+ var premTexture, pmremCube;`
`73`	`73`
`74`	`74`	`function updatePREM( textureCube ) {`
`75`	`75`