ObjLoader2Parser materials are not applied in worker #17711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ditionally, allow material override from OBJLoader2.addMaterials to MaterialHandler.addMaterials
Owner
|
Thanks! |
Contributor
Author
|
One can observe you are currently synced to CEST! 😉 |
Owner
|
In Stockholm, extremely jet-lagged though 😅 |
Contributor
Author
|
Saw your tweet yesterday. Have a good time and try visit a day-light bar or cafe against the jet lag. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17615 Material assignment is no properly done when Parser is run in worker.
Additionally, allow material override from OBJLoader2.addMaterials to MaterialHandler.addMaterials