Materials not correctly applied by ObjLoader2Parallel (jsm)

[Jens84]

Description of the problem

The OBJLoader2Parallel does not correctly apply given materials, added by calling addMaterials(materials) before loading, when using web workers (executeParallel = true) and falls back to default materials instead.

In WorkerRunner.js, payload.materials are applied to the corresponding instance of OBJLoader2Parser using ObjectManipulator.

three.js/examples/jsm/loaders/obj2/worker/parallel/WorkerRunner.js

Lines 52 to 54 in a84f4c4

	ObjectManipulator.applyProperties( parser, payload.params );
	ObjectManipulator.applyProperties( parser, payload.materials );
	ObjectManipulator.applyProperties( parser, callbacks );

However, in order for the ObjectManipulator to call the appropriate method, which is setMaterials(payload.materials), the second argument (L53) should be an object with materials as key and payload.materials as value.

three.js/examples/jsm/loaders/obj2/utils/ObjectManipulator.js

Lines 14 to 37 in a84f4c4

	applyProperties: function ( objToAlter, params, forceCreation ) {
	// fast-fail
	if ( objToAlter === undefined || objToAlter === null || params === undefined || params === null ) return;
	let property, funcName, values;
	for ( property in params ) {
	funcName = 'set' + property.substring( 0, 1 ).toLocaleUpperCase() + property.substring( 1 );
	values = params[ property ];
	if ( typeof objToAlter[ funcName ] === 'function' ) {
	objToAlter[ funcName ]( values );
	} else if ( objToAlter.hasOwnProperty( property ) || forceCreation ) {
	objToAlter[ property ] = values;
	}
	}
	}

I would suggest to move materials (L193) to the params object above in OBJLoader2Parallel.js and remove L53 from WorkerRunner.js:

three.js/examples/jsm/loaders/OBJLoader2Parallel.js

Lines 185 to 193 in a84f4c4

	params: {
	modelName: this.modelName,
	instanceNo: this.instanceNo,
	useIndices: this.parser.useIndices,
	disregardNormals: this.parser.disregardNormals,
	materialPerSmoothingGroup: this.parser.materialPerSmoothingGroup,
	useOAsMesh: this.parser.useOAsMesh,
	},
	materials: this.materialHandler.getMaterialsJSON(),

Three.js version

• Dev
• r108
• ...

Browser

• All of them
• Chrome
• Firefox
• Internet Explorer

OS

• All of them
• Windows
• macOS
• Linux
• Android
• iOS

Hardware Requirements (graphics card, VR Device, ...)

[Mugen87]

/ping @kaisalmen (sorry for the many pings lately^^)

[kaisalmen]

/ping @kaisalmen (sorry for the many pings lately^^)

No worries. Good to see people still use the loader...

@Jens84 Thank you for the suggestion. I will check and fix this. It probably broke when I removed the default material init from the constructor of MaterialHandler. It will be fixed in r110 as r109 was just released.

[kaisalmen]

@Jens84 your analysis perfectly outlined the solution. Thank you 👍 This was broken for a longer time and not recently, I think. I exposed material override in OBJLoader2#addMaterials with the above PR as well.