-
-
Notifications
You must be signed in to change notification settings - Fork 36.1k
Run all TS code (including examples/jsm) through tsc when linting. #17415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The added dev dependency on @types/webgl2 is to let tsc know about Not sure what the status is of these. |
Those files are included by |
No they're not. WebGLRenderer.js yes, but not WebGLRenderer.d.ts. Line 175 in f3205d7
Yes it does. Though only the ones it gets to from the entry points. The entry point was src/Three.d.ts, which due to the commented import left out the files I mentioned. |
c68b6ad to
a6df957
Compare
|
Looks good! I think we should give this a try 👍 |
|
Thanks! |
You're welcome! |
#17409