Skip to content

Conversation

@sciecode
Copy link
Contributor

@sciecode sciecode commented Jul 23, 2019

Fixes #17068.

And as suggested in #17068 (comment), adds
uv_grid_opengl
uv_grid_directx

@WestLangley
Copy link
Collaborator

Maybe related, but for a separate PR:

I think the parametric geometries need to be checked. I know the plane vertex normals are negative, which is odd, so there is some weirdness going on...

@Mugen87
Copy link
Collaborator

Mugen87 commented Jul 23, 2019

I'm glad this issue is finally fixed.

@Mugen87
Copy link
Collaborator

Mugen87 commented Jul 23, 2019

I think the parametric geometries need to be checked. I know the plane vertex normals are negative, which is odd, so there is some weirdness going on...

see #12404 (comment)

@Mugen87 Mugen87 merged commit feb11a5 into mrdoob:dev Jul 23, 2019
@sciecode sciecode deleted the dev-uvgrid branch July 23, 2019 18:55
@Mugen87 Mugen87 added this to the r107 milestone Jul 23, 2019
@mrdoob
Copy link
Owner

mrdoob commented Jul 24, 2019

Thanks!

lymzcq1993 added a commit to lymzcq1993/three.js that referenced this pull request Sep 16, 2019
This reverts commit feb11a5, reversing
changes made to b2d6944.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Examples: Replace UV debug texture.

4 participants