OBJLoader2 V2.5.1 #16343
Merged
OBJLoader2 V2.5.1 #16343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrdoob#15468. OBJLoader2: Reduced log level from warn to info when defaultMaterial is used when material name was not resolvable.
…callback naming Versions are only printed once in the logs
Contributor
Author
|
This is good to go now! |
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following issues:
#15219: Materials are initialised as objects.
#15468. OBJLoader2: Reduced log level from warn to info when defaultMaterial is used when material name was not resolvable.
#16307: Backported onError function usage from OBJLoader2/Parser V3. Unified callback naming
From now on versions are only printed once in the logs.