Skip to content

fix warnings sea3d and nodematerials #16231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 13, 2019
Merged

fix warnings sea3d and nodematerials #16231

merged 8 commits into from
Apr 13, 2019

Conversation

@sunag
Copy link
Collaborator

@sunag sunag commented Apr 12, 2019

@sunag sunag changed the title sea3d - fix power of 2 texture fix warnings sea3d and nodematerials Apr 12, 2019
@sunag
Copy link
Collaborator Author

sunag commented Apr 12, 2019

i will fixed the warns in nodematerial

@sunag
Copy link
Collaborator Author

sunag commented Apr 12, 2019 •
edited
Loading

@WestLangley Did this fix the nodematerial examples?

@WestLangley
Copy link
Collaborator

WestLangley commented Apr 12, 2019

@WestLangley Did this fix the nodematerial examples?

Yes.

I see however, in examples/webgl_materials_nodes.html, adv / translucent option, plus in some other cases, I get this warning:

getsize() now requires a Vector2 as an argument

@WestLangley
Copy link
Collaborator

WestLangley commented Apr 12, 2019

You need to fix getsize() in ResolutionNode.js.

@sunag
Copy link
Collaborator Author

sunag commented Apr 12, 2019

@WestLangley I guess it's okay now?

@WestLangley
Copy link
Collaborator

WestLangley commented Apr 12, 2019

@sunag Thanks!

@sunag
Copy link
Collaborator Author

sunag commented Apr 12, 2019

👍

@mrdoob mrdoob added this to the r104 milestone Apr 13, 2019
@mrdoob mrdoob merged commit ec325de into mrdoob:dev Apr 13, 2019
@mrdoob
Copy link
Owner

mrdoob commented Apr 13, 2019

Thanks!

@sunag sunag deleted the dev-fix-warnings branch June 3, 2019 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r104

Development

Successfully merging this pull request may close these issues.

3 participants

@sunag @WestLangley @mrdoob