Set Pass.renderToScreen automatically in EffectComposer #16033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrdoob
reviewed
Mar 22, 2019
|
|
||
| isLastEnabledPass: function ( passIndex ) { | ||
|
|
||
| for ( i = passIndex + 1; i < this.passes.length; ++i ) { |
There was a problem hiding this comment.
We should initialise i.
for ( var i = passIndex + 1; i < this.passes.length; i ++ ) {There was a problem hiding this comment.
Huh, that was a silly mistake. Amended the commit now with "var".
Oletus
force-pushed
the
postprocessing-render-to-screen
branch
from
92e1b47 to
adc65f6
Compare
The last enabled EffectComposer pass is the only one that can really render to the screen, so we can set the renderToScreen flag in the passes automatically. The only case where EffectComposers don't render to the screen at all in the current examples is webgl_materials_skin, that sets up multiple EffectComposers and then combines their results. For that special case we now have a renderToScreen flag in EffectComposer. This simplifies setting up EffectComposer and will make further enhancements a bit easier.
Oletus
force-pushed
the
postprocessing-render-to-screen
branch
from
adc65f6 to
911e4b2
Compare
|
Thanks! |
WestLangley
reviewed
Mar 22, 2019
| this.clear = false; | ||
|
|
||
| // if set to true, the result of the pass is rendered to screen | ||
| // if set to true, the result of the pass is rendered to screen. This is set automatically by EffectComposer. |
There was a problem hiding this comment.
Should Pass.renderToScreen be private, then?
There was a problem hiding this comment.
At least one example uses Pass without using EffectComposer and needs to set this. Maybe it would be better to make this private but then we'd have to at least refactor that example first.
There was a problem hiding this comment.
That example is webgl_postprocessing_unreal_bloom.html.
Closed
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last enabled EffectComposer pass is the only one that can really render to the screen, so we can set the renderToScreen flag in the passes automatically. The only case where EffectComposers don't render to the screen at all in the current examples is webgl_materials_skin, that sets up multiple EffectComposers and then combines their results. For that special case we now have a renderToScreen flag in EffectComposer.
This simplifies setting up EffectComposer and will make further enhancements a bit easier.