Skip to content

Conversation

@mrdoob
Copy link
Owner

@mrdoob mrdoob commented Mar 17, 2018

Progress... #13478

screen shot 2018-03-17 at 03 07 09

@mrdoob mrdoob added this to the r92 milestone Mar 17, 2018
@mrdoob mrdoob merged commit 206aa14 into dev Mar 17, 2018
@mrdoob mrdoob deleted the svgloader branch March 17, 2018 10:09
@jonobr1 jonobr1 mentioned this pull request Mar 17, 2018
@Mugen87
Copy link
Collaborator

Mugen87 commented Mar 17, 2018

When I zoom in near the tiger, I can see a lot of z-fighting between the single faces. Setting depthWrite to false in the shape material should solve the problem.

@mrdoob
Copy link
Owner Author

mrdoob commented Mar 17, 2018

Yeah... Or disable depthTest? There is a few challenges with this one.

@Mugen87
Copy link
Collaborator

Mugen87 commented Mar 17, 2018

Um...if you just disable depthWrite, objects closer to the camera are still drawn correctly (they are not overdrawn by the shapes). That's not the case with a disabled depthTest.

@mrdoob
Copy link
Owner Author

mrdoob commented Mar 18, 2018

Worth a try!

@WestLangley
Copy link
Collaborator

@mrdoob I think you are going to have to ensure that the intended render order is maintained.

@mrdoob
Copy link
Owner Author

mrdoob commented Mar 20, 2018

I think the nodes order in svg is already the intended render order. Unless someone is using z-index, but that's more of a html thing.

@WestLangley
Copy link
Collaborator

I think the nodes order in svg is already the intended render order.

Right. But the renderer sorts objects by default. Perhaps it defaults to sorting by id in this case...

@mrdoob
Copy link
Owner Author

mrdoob commented Mar 21, 2018

Yep!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants