Skip to content

build: export config to local build #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2021
Merged

build: export config to local build #322

merged 1 commit into from
Dec 13, 2021

Conversation

JohelEGP
Copy link
Collaborator

This implements mpusz/cmake-scripts#2 on this repository, which resolved #102. Seems like its effect was lost along the build system refactors.

@gitpod-io
Copy link

gitpod-io bot commented Dec 11, 2021

@JohelEGP
Copy link
Collaborator Author

JohelEGP commented Dec 12, 2021 •
edited
Loading

@mpusz Can you add a test for this? It'd be just the same as the current test for an installed prefix, like https://github.com/mpusz/units/runs/4494977650?check_suite_focus=true#step:17:1, but instead of -DCMAKE_INSTALL_PREFIX=../../../build/Debug/test_package, it should use -Dmp-units_DIR=build-directory-of-mp-units. Added.

@JohelEGP JohelEGP force-pushed the local_build branch 2 times, most recently from 461d4f7 to 86308db Compare December 12, 2021 21:57
@JohelEGP
Copy link
Collaborator Author

@mpusz Can you add a test for this? It'd be just the same as the current test for an installed prefix, like https://github.com/mpusz/units/runs/4494977650?check_suite_focus=true#step:17:1, but instead of -DCMAKE_INSTALL_PREFIX=../../../build/Debug/test_package, it should use -Dmp-units_DIR=build-directory-of-mp-units.

I added the test.

mpusz
mpusz approved these changes Dec 13, 2021
View reviewed changes
Copy link
Owner

@mpusz mpusz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mpusz mpusz merged commit 3bf3beb into mpusz:master Dec 13, 2021
@JohelEGP JohelEGP deleted the local_build branch December 13, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpusz mpusz mpusz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow using local build through find_package
2 participants
@JohelEGP @mpusz