Skip to content

Fix/vendor node output #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+6 −3
Closed

Fix/vendor node output #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8f2f37
FIX: Suppress stdout in vendor-node.cjs version check
SyedaAnshrahGillani Oct 22, 2025
9eb41cb
FIX: Improve protoc vendoring script error handling and output
SyedaAnshrahGillani Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/vendor-node.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ rmSync(tmpDir, { recursive: true, force: true });

function tryExecSync(cmd) {
try {
return execSync(cmd, { stdio: 'inherit' }).toString('utf-8');
return execSync(cmd, { stdio: 'pipe' }).toString('utf-8');
} catch (_) {
return '';
}
Expand Down
7 changes: 5 additions & 2 deletions scripts/vendor-protoc.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,14 @@ mkdirSync(dstDir, { recursive: true });
chmodSync(binDst, newMode);

console.log('Downloaded protoc to', binDst);
})().catch((err) => console.log('Script failed:', err));
})().catch((err) => {
console.log('Script failed:', err);
process.exit(1);
});

function tryExecSync(cmd) {
try {
return execSync(cmd, { stdio: 'inherit' }).toString('utf-8');
return execSync(cmd, { stdio: 'pipe' }).toString('utf-8');
} catch (_) {
return '';
}
Expand Down