Fix/vendor node output #274
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses two minor but impactful issues in the project's vendoring scripts
(scripts/vendor-node.cjs and scripts/vendor-protoc.cjs), enhancing the robustness of the development
setup and improving the overall developer experience.
Changes Introduced:
scripts/vendor-node.cjs- Suppressnode --versionoutput:Node.js version. This caused the node --version output to be printed to the console every time
the bootstrap script ran this check, leading to unnecessary console noise.
during the bootstrap process. Developers will now only see relevant messages, improving clarity
and focus.
scripts/vendor-protoc.cjs- Improve error handling and suppressprotoc --versionoutput:but did not terminate the script with process.exit(1). If protoc vendoring failed, the bootstrap
process would continue, potentially leading to confusing cascading errors later on.
'inherit' for the protoc --version check, adding unnecessary output to the console.
immediate, clear feedback if protoc vendoring encounters an issue. This prevents wasted time
debugging subsequent failures. The stdio: 'pipe' change also contributes to a cleaner console
output, consistent with the vendor-node.cjs fix.
These changes are bug fixes that enhance the reliability and user-friendability of the project's
development setup, aligning with the project's contribution policy.