Skip to content

APISD-1390 Update counterparty type #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

APISD-1390 Update counterparty type #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/requests/types/unauthenticated.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import {ApiResponse, ExtraOptions} from "../../request"
import {WellKnownConnection} from "../../schema/connection"
import {GlobalCounterpartiesSearchParams, GlobalCounterparty} from "../../schema/counterparty"
import {GlobalCounterpartiesSearchParams, GlobalCounterpartyV3} from "../../schema/counterparty"

export interface UnauthenticatedRequests {
getGlobalCounterparties: (
params?: GlobalCounterpartiesSearchParams,
options?: ExtraOptions
) => Promise<ApiResponse<GlobalCounterparty[]>>
) => Promise<ApiResponse<GlobalCounterpartyV3[]>>

listConnections: (query?: {clientId?: string}) => Promise<WellKnownConnection[]>
listAPIConnections: (query?: {clientId?: string}) => Promise<WellKnownConnection[]>
Expand Down
23 changes: 14 additions & 9 deletions src/schema/counterparty.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,19 @@ export interface GlobalCounterpartiesSearchParams extends SearchParams {
counterpartiesVersion?: "v2" | "v3"
}

export interface GlobalCounterparty {
export interface GlobalCounterpartyV3 {
id: string
label: string
companyName: string
logo: string
website: string
mcc: {
code?: string
name?: string
}
name: string
parentId?: string
parentName?: string
fullCompanyName?: string | null
logoUrl?: string | null
website?: string | null
merchantCategoryCode?: string | null
merchantCategoryDescription?: string | null
registeredLocation?: string | null
categoryId?: string
analyticalCategory?: string
transactionCategoryId?: string
transactionCategory?: string
}
Loading