APISD-1390 Update counterparty type

[adamtmh]

Description

A client noticed that the return type for the getGlobalCounterparties method is incorrect as it's still on the v2. This changes it so that it has the v3 counterparty return type. I guess this might not be correct for those clients still using the v2 enpdoint, but figure the latest version of the moneyhub-api-client should use the latest counterparties version. Would welcome opinions on this though.

[cursor]

Bug: Mismatched API Version and Return Type

The getGlobalCounterparties function's return type is hardcoded to GlobalCounterpartyV3[], but its GlobalCounterpartiesSearchParams still permits counterpartiesVersion: "v2". This creates a type-runtime mismatch: requesting v2 data returns a v2 structure at runtime, while TypeScript expects v3, leading to potential runtime errors when accessing incompatible fields (e.g., label vs name).

src/requests/types/unauthenticated.ts#L5-L9

moneyhub-api-client/src/requests/types/unauthenticated.ts

Lines 5 to 9 in d850eb5

	export interface UnauthenticatedRequests {
	getGlobalCounterparties: (
	params?: GlobalCounterpartiesSearchParams,
	options?: ExtraOptions
	) => Promise<ApiResponse<GlobalCounterpartyV3[]>>

Fix in Cursor • Fix in Web

---

Was this report helpful? Give feedback by reacting with 👍 or 👎

[ozamarripamoneyhub]

We could:

• Add as a type that it can be either of them (V2 or V3)
• Just set the default as V3
• Add auxiliary function for V2 'getGlobalCounterpartiesV2'