Skip to content

FIX-#7669: Respect eval(inplace=False). #7670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2025
Merged

FIX-#7669: Respect eval(inplace=False). #7670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modin/core/computation/eval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ def eval(
try:
target = env.target
if isinstance(target, BasePandasDataset):
target = target.copy(deep=None)
target = target.copy(deep=True)
else:
target = target.copy()
except AttributeError as err:
Expand Down
11 changes: 11 additions & 0 deletions modin/tests/pandas/dataframe/test_udf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,17 @@ def test_eval_scalar():
assert df.eval("1") == 1


@pytest.mark.parametrize("engine", ("numexpr", "python"))
def test_eval_not_inplace_does_not_change_input_dataframe(engine):
snow_df, pandas_df = create_test_dfs({"a": [1, 2, 3]})
original_pandas = pandas_df.copy()
snow_result = snow_df.eval("b = a + 1", inplace=False, engine=engine)
pandas_result = pandas_df.eval("b = a + 1", inplace=False, engine=engine)
df_equals(snow_df, original_pandas)
df_equals(pandas_df, original_pandas)
df_equals(snow_result, pandas_result)


TEST_VAR = 2


Expand Down
Loading