FIX-#7669: Respect eval(inplace=False). #7670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sfc-gh-mvashishtha <[email protected]>
sfc-gh-mvashishtha
requested review from
devin-petersohn,
mvashishtha,
RehanSD,
YarShev,
vnlitvinov,
anmyachev,
dchigarev and
a team
as code owners
sfc-gh-joshi
approved these changes
Sep 16, 2025
sfc-gh-jkew
pushed a commit
that referenced
this pull request
Sep 19, 2025
Prior to this commit, calling `DataFrame.eval(inplace=False, engine='python')` with an assignment would incorrectly update the input dataframe. The root cause was calling `copy(deep=None)` instead of `copy(deep=True)`. We need to insert new columns to a deep copy of the input dataframe. `deep=None` is not part of the `copy` API at all, so we don't need to fix `copy()` behavior. It happens that `deep=None` does a deep copy in pandas, which is where we got the `deep=None` code from. Resolves #7669 Signed-off-by: sfc-gh-mvashishtha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, calling
DataFrame.eval(inplace=False, engine='python')with an assignment would incorrectly update the input dataframe. The root cause was callingcopy(deep=None)instead ofcopy(deep=True). We need to insert new columns to a deep copy of the input dataframe.deep=Noneis not part of thecopyAPI at all, so we don't need to fixcopy()behavior. It happens thatdeep=Nonedoes a deep copy in pandas, which is where we got thedeep=Nonecode from.Resolves #7669