Skip to content

FEAT-#7647: Shorten the hybrid progress bar text #7648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 11, 2025
Merged

FEAT-#7647: Shorten the hybrid progress bar text #7648

merged 7 commits into from
Aug 11, 2025

Conversation

sfc-gh-jkew
Copy link
Contributor

@sfc-gh-jkew sfc-gh-jkew commented Aug 8, 2025 •
edited
Loading

  • Make it fixed width
  • Format row/col estimates with general formatting and limit to 6 characters
  • Trim the operation name if needed, prefer the method over the object

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Shorten the hybrid progress bar text #7647
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@sfc-gh-jkew
FEAT-#7647 Shorten the hybrid progress bar text
83d7369 
- Make it fixed width
- Format row/col estimates with general formatting and limit to 6 characters
- Trim the operation name if needed, prefer the method over the object
@sfc-gh-jkew sfc-gh-jkew marked this pull request as ready for review August 8, 2025 17:02
@sfc-gh-jkew sfc-gh-jkew changed the title FEAT-#7647 Shorten the hybrid progress bar text FEAT-#7647: Shorten the hybrid progress bar text Aug 8, 2025
sfc-gh-joshi
sfc-gh-joshi reviewed Aug 8, 2025
View reviewed changes
@sfc-gh-jkew sfc-gh-jkew enabled auto-merge (squash) August 9, 2025 17:07
@sfc-gh-jkew sfc-gh-jkew merged commit cf9590b into main Aug 11, 2025
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-joshi sfc-gh-joshi sfc-gh-joshi approved these changes

@devin-petersohn devin-petersohn Awaiting requested review from devin-petersohn devin-petersohn is a code owner

@mvashishtha mvashishtha Awaiting requested review from mvashishtha mvashishtha is a code owner

@RehanSD RehanSD Awaiting requested review from RehanSD RehanSD is a code owner

@YarShev YarShev Awaiting requested review from YarShev YarShev is a code owner

@vnlitvinov vnlitvinov Awaiting requested review from vnlitvinov vnlitvinov is a code owner

@anmyachev anmyachev Awaiting requested review from anmyachev anmyachev is a code owner

@dchigarev dchigarev Awaiting requested review from dchigarev dchigarev is a code owner

+1 more reviewer

@sfc-gh-dolee sfc-gh-dolee sfc-gh-dolee left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shorten the hybrid progress bar text
3 participants
@sfc-gh-jkew @sfc-gh-joshi @sfc-gh-dolee