Skip to content

Conversation

@sfc-gh-mvashishtha
Copy link
Contributor

@sfc-gh-mvashishtha sfc-gh-mvashishtha commented Jan 16, 2025

What do these changes do?

Rename internal to_dataframe methods to to_interchange_dataframe, and internal from_dataframe methods to from_interchange_dataframe.

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Query compiler method to_dataframe should be named to_interchange or similar #7418
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@sfc-gh-mvashishtha sfc-gh-mvashishtha changed the title REFACTOR-#7418: Rename to_dataframe to to_interchange_dataframe. REFACTOR-#7418: Rename internal interchange protocol methods. Jan 16, 2025
@sfc-gh-mvashishtha sfc-gh-mvashishtha merged commit 4cae985 into modin-project:main Jan 16, 2025
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Query compiler method to_dataframe should be named to_interchange or similar

3 participants