Refactor folder structure #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avanhatt
reviewed
Aug 12, 2021
compiler/rustc_codegen_llvm/src/gotoc/mir_to_goto/metadata/current_fn.rs
Outdated
Show resolved
Hide resolved
danielsn
force-pushed
the
folder-structure
branch
from
b69a872 to
cc1b6c0
Compare
avanhatt
reviewed
Aug 16, 2021
| use crate::gotoc::mir_to_goto::GotocCtx; | ||
|
|
||
| // Should move into rvalue | ||
| //make this a member function |
Contributor
There was a problem hiding this comment.
Should this have an issue?
chinmaydd
reviewed
Aug 16, 2021
| } | ||
|
|
||
| //TODO fix this name | ||
| pub fn codegen_span_option2(&self, sp: Option<Span>) -> Location { |
There was a problem hiding this comment.
Can we fix the names for these as part of this refactor?
adpaco-aws
pushed a commit
that referenced
this pull request
Aug 17, 2021
* Created mir_to_goto folder, moved monomorphize into it * moved metadata files into metadata folder * moved codegen files to codegen folder * moved stubs and hooks to mir_to_goto * moved the final files into mir_to_goto * Comments * suppress warnings * added missing file * rename metadata as per PR comments * Remove pub modifier on modules that don't need it * Moved tuple_fld so that typ can be private mod * removed pub mod from stubs * moved overrides into their own folder * moved assumptions into codegen * utils folder * init debug properly * renamed backend to compiler_interface * gotoCtx should just take a MIR context at construction time * move more stuff out of utils to where it goes * names get their own util * better import in hooks
adpaco-aws
pushed a commit
that referenced
this pull request
Aug 24, 2021
* Created mir_to_goto folder, moved monomorphize into it * moved metadata files into metadata folder * moved codegen files to codegen folder * moved stubs and hooks to mir_to_goto * moved the final files into mir_to_goto * Comments * suppress warnings * added missing file * rename metadata as per PR comments * Remove pub modifier on modules that don't need it * Moved tuple_fld so that typ can be private mod * removed pub mod from stubs * moved overrides into their own folder * moved assumptions into codegen * utils folder * init debug properly * renamed backend to compiler_interface * gotoCtx should just take a MIR context at construction time * move more stuff out of utils to where it goes * names get their own util * better import in hooks
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
* Created mir_to_goto folder, moved monomorphize into it * moved metadata files into metadata folder * moved codegen files to codegen folder * moved stubs and hooks to mir_to_goto * moved the final files into mir_to_goto * Comments * suppress warnings * added missing file * rename metadata as per PR comments * Remove pub modifier on modules that don't need it * Moved tuple_fld so that typ can be private mod * removed pub mod from stubs * moved overrides into their own folder * moved assumptions into codegen * utils folder * init debug properly * renamed backend to compiler_interface * gotoCtx should just take a MIR context at construction time * move more stuff out of utils to where it goes * names get their own util * better import in hooks
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
* Created mir_to_goto folder, moved monomorphize into it * moved metadata files into metadata folder * moved codegen files to codegen folder * moved stubs and hooks to mir_to_goto * moved the final files into mir_to_goto * Comments * suppress warnings * added missing file * rename metadata as per PR comments * Remove pub modifier on modules that don't need it * Moved tuple_fld so that typ can be private mod * removed pub mod from stubs * moved overrides into their own folder * moved assumptions into codegen * utils folder * init debug properly * renamed backend to compiler_interface * gotoCtx should just take a MIR context at construction time * move more stuff out of utils to where it goes * names get their own util * better import in hooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Refactored RMC code to have a proper directory structure that groups similar code together
Resolved issues:
Resolves #ISSUE-NUMBER
Call-outs:
The function
tuple_fldwhich belongs in utils.rs had been intyp.rs. I found this becuase typ.rs needed to be public only to export that function. I moved it.Testing:
How is this change tested? Existing regression test
Is this a refactor change? Yes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.