Condition property on .NET FX MSBuild #15054
Merged
+3
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `BuildWithNetFrameworkHostedCompiler` property forces a .NET Framework specific compiler package to be used. This property was being unconditionally set which meant it loaded inside of `dotnet build`. In that environment the build task is invalid / unsupported. In this particular case the task ended up throwing errors trying to connect to the compiler server. That is an expected failure path in the build task and it will fallback silently to csc.exe. That meant this went unnoticed as builds remained functional, just significantly slower. Related: dotnet/sdk#48557
lewing
approved these changes
Apr 17, 2025
rainersigwald
approved these changes
Apr 17, 2025
ViktorHofer
reviewed
Apr 18, 2025
Directory.Build.props
Outdated
| <IncludeSymbols>true</IncludeSymbols> | ||
| <!-- Workaround for AD0001 in analyzers with .NET 9. See https://github.com/dotnet/arcade/issues/14311 --> | ||
| <BuildWithNetFrameworkHostedCompiler>true</BuildWithNetFrameworkHostedCompiler> | ||
| <BuildWithNetFrameworkHostedCompiler Condition="'$(MSBuildRuntimeType)' == 'Full'">true</BuildWithNetFrameworkHostedCompiler> |
There was a problem hiding this comment.
We shouldn't be setting this property in vstest anymore. That was only necessary for a short period of time during .NET 9. Please also remove the comment above. GH doesn't let me do that.
Suggested change
| <BuildWithNetFrameworkHostedCompiler Condition="'$(MSBuildRuntimeType)' == 'Full'">true</BuildWithNetFrameworkHostedCompiler> |
ViktorHofer
approved these changes
Apr 18, 2025
nohwnd
approved these changes
Apr 21, 2025
This was referenced Oct 2, 2025
Closed
Merged
This was referenced Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
BuildWithNetFrameworkHostedCompilerproperty forces a .NET Framework specific compiler package to be used. This property was being unconditionally set which meant it loaded inside ofdotnet build. In that environment the build task is invalid / unsupported.In this particular case the task ended up throwing errors trying to connect to the compiler server. That is an expected failure path in the build task and it will fallback silently to csc.exe. That meant this went unnoticed as builds remained functional, just significantly slower.
Related: dotnet/sdk#48557