Respect BuildWithNetFrameworkHostedCompiler on netxf #48557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the build to only respect BuildWithNetFrameworkHostedCompiler on full framework msbuild. Without this guard customers can accidentally force the use of Microsoft.Net.Sdk.Compilers.Toolset on a core msbuild. That leads to runtime errors as the build tasks inside are .NET Framework specific. These errors tend to be silent as they are in the server connection code which will fall back to csc.exe invocation on error
ghost
added
rainersigwald
approved these changes
Apr 17, 2025
RikkiGibson
approved these changes
Apr 17, 2025
jaredpar
added a commit
to jaredpar/vstest
that referenced
this pull request
Apr 17, 2025
The `BuildWithNetFrameworkHostedCompiler` property forces a .NET Framework specific compiler package to be used. This property was being unconditionally set which meant it loaded inside of `dotnet build`. In that environment the build task is invalid / unsupported. In this particular case the task ended up throwing errors trying to connect to the compiler server. That is an expected failure path in the build task and it will fallback silently to csc.exe. That meant this went unnoticed as builds remained functional, just significantly slower. Related: dotnet/sdk#48557
nohwnd
pushed a commit
to microsoft/vstest
that referenced
this pull request
Apr 21, 2025
* Condition property on .NET FX MSBuild The `BuildWithNetFrameworkHostedCompiler` property forces a .NET Framework specific compiler package to be used. This property was being unconditionally set which meant it loaded inside of `dotnet build`. In that environment the build task is invalid / unsupported. In this particular case the task ended up throwing errors trying to connect to the compiler server. That is an expected failure path in the build task and it will fallback silently to csc.exe. That meant this went unnoticed as builds remained functional, just significantly slower. Related: dotnet/sdk#48557 * pr feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the build to only respect
BuildWithNetFrameworkHostedCompiler on full framework msbuild. Without this guard customers can accidentally force the use of Microsoft.Net.Sdk.Compilers.Toolset on a core msbuild. That leads to runtime errors as the build tasks inside are .NET Framework specific. These errors tend to be silent as they are in the server connection code which will fall back to csc.exe invocation on error