-
Notifications
You must be signed in to change notification settings - Fork 7.1k
[ms-gsl] Bump GSL to 4.0.0 #22791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[ms-gsl] Bump GSL to 4.0.0 #22791
Changes from 15 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
56c1709
Bump GSL to 4.0.0
dmitrykobets-msft 1935ea7
Update version database
dmitrykobets-msft 2e28474
Fix typo
dmitrykobets-msft d2b3c44
Add missing file
dmitrykobets-msft c1dfa92
Update version database
dmitrykobets-msft 3539302
GSL portfile properly expose Microsoft.GSL package
dmitrykobets-msft 4de3640
Merge branch 'microsoft:master' into master
dmitrykobets-msft ff0f4fd
Merge branch 'master' of https://github.com/dmitrykobets-msft/vcpkg
dmitrykobets-msft e8e2845
Update version database
dmitrykobets-msft 6f71b66
Respond to review
dmitrykobets-msft 8c9fce4
Update version database
dmitrykobets-msft 83e7e35
Update version database v2
dmitrykobets-msft f772ac6
Merge branch 'microsoft:master' into master
dmitrykobets-msft c242432
Update release ref
dmitrykobets-msft 99dc37b
Update version database
dmitrykobets-msft d2ae5ce
Respond to review
dmitrykobets-msft 4931ce5
Update version database
dmitrykobets-msft 65ad9f9
Add patch to SEAL to link to correct GSL version
dmitrykobets-msft f263756
Merge branch 'microsoft:master' into master
dmitrykobets-msft a161b7a
Merge branch 'master' of https://github.com/dmitrykobets-msft/vcpkg
dmitrykobets-msft 8816a7e
Update version database
dmitrykobets-msft 53c209a
Update version database v2
dmitrykobets-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,80 @@ | ||
diff --git a/interface/coroutine/net.h b/interface/coroutine/net.h | ||
index 17b70a8..3c44827 100644 | ||
--- a/interface/coroutine/net.h | ||
+++ b/interface/coroutine/net.h | ||
@@ -344,7 +344,7 @@ void poll_net_tasks(uint64_t nano) noexcept(false); | ||
* @ingroup Network | ||
*/ | ||
uint32_t get_address(const addrinfo& hint, // | ||
- gsl::czstring<> host, gsl::czstring<> serv, | ||
+ gsl::czstring host, gsl::czstring serv, | ||
gsl::span<sockaddr_in> output) noexcept; | ||
|
||
/** | ||
@@ -361,7 +361,7 @@ uint32_t get_address(const addrinfo& hint, // | ||
* @ingroup Network | ||
*/ | ||
uint32_t get_address(const addrinfo& hint, // | ||
- gsl::czstring<> host, gsl::czstring<> serv, | ||
+ gsl::czstring host, gsl::czstring serv, | ||
gsl::span<sockaddr_in6> output) noexcept; | ||
|
||
/** | ||
@@ -377,7 +377,7 @@ uint32_t get_address(const addrinfo& hint, // | ||
* @ingroup Network | ||
*/ | ||
uint32_t get_name(const sockaddr_in& addr, // | ||
- gsl::zstring<NI_MAXHOST> name, gsl::zstring<NI_MAXSERV> serv, | ||
+ gsl::basic_zstring<char, NI_MAXHOST> name, gsl::basic_zstring<char, NI_MAXSERV> serv, | ||
int32_t flags = NI_NUMERICHOST | NI_NUMERICSERV) noexcept; | ||
|
||
/** | ||
@@ -392,7 +392,7 @@ uint32_t get_name(const sockaddr_in& addr, // | ||
* @ingroup Network | ||
*/ | ||
uint32_t get_name(const sockaddr_in6& addr, // | ||
- gsl::zstring<NI_MAXHOST> name, gsl::zstring<NI_MAXSERV> serv, | ||
+ gsl::basic_zstring<char, NI_MAXHOST> name, gsl::basic_zstring<char, NI_MAXSERV> serv, | ||
int32_t flags = NI_NUMERICHOST | NI_NUMERICSERV) noexcept; | ||
|
||
} // namespace coro | ||
diff --git a/modules/net/resolver.cpp b/modules/net/resolver.cpp | ||
index 21a9800..5328939 100644 | ||
--- a/modules/net/resolver.cpp | ||
+++ b/modules/net/resolver.cpp | ||
@@ -9,7 +9,7 @@ namespace coro { | ||
|
||
GSL_SUPPRESS(type .1) | ||
uint32_t get_name(const sockaddr_in& addr, // | ||
- gsl::zstring<NI_MAXHOST> name, gsl::zstring<NI_MAXSERV> serv, | ||
+ gsl::basic_zstring<char, NI_MAXHOST> name, gsl::basic_zstring<char, NI_MAXSERV> serv, | ||
int32_t flags) noexcept { | ||
const auto* ptr = reinterpret_cast<const sockaddr*>(addressof(addr)); | ||
return ::getnameinfo(ptr, sizeof(sockaddr_in), // | ||
@@ -20,7 +20,7 @@ uint32_t get_name(const sockaddr_in& addr, // | ||
|
||
GSL_SUPPRESS(type .1) | ||
uint32_t get_name(const sockaddr_in6& addr, // | ||
- gsl::zstring<NI_MAXHOST> name, gsl::zstring<NI_MAXSERV> serv, | ||
+ gsl::basic_zstring<char, NI_MAXHOST> name, gsl::basic_zstring<char, NI_MAXSERV> serv, | ||
int32_t flags) noexcept { | ||
const auto* ptr = reinterpret_cast<const sockaddr*>(addressof(addr)); | ||
return ::getnameinfo(ptr, sizeof(sockaddr_in6), // | ||
@@ -58,7 +58,7 @@ auto get_address(addrinfo* list, sockaddr_in6 addr) noexcept | ||
} | ||
|
||
uint32_t get_address(const addrinfo& hint, // | ||
- gsl::czstring<> host, gsl::czstring<> serv, | ||
+ gsl::czstring host, gsl::czstring serv, | ||
gsl::span<sockaddr_in> output) noexcept { | ||
addrinfo* list = nullptr; | ||
if (const auto ec = ::getaddrinfo(host, serv, // | ||
@@ -74,7 +74,7 @@ uint32_t get_address(const addrinfo& hint, // | ||
} | ||
|
||
uint32_t get_address(const addrinfo& hint, // | ||
- gsl::czstring<> host, gsl::czstring<> serv, | ||
+ gsl::czstring host, gsl::czstring serv, | ||
gsl::span<sockaddr_in6> output) noexcept { | ||
addrinfo* list = nullptr; | ||
if (const auto ec = ::getaddrinfo(host, serv, // |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,7 +1,16 @@ | ||||||
{ | ||||||
"name": "ms-gsl", | ||||||
"version-string": "3.1.0", | ||||||
"port-version": 1, | ||||||
"version-string": "4.0.0", | ||||||
|
"version-string": "4.0.0", | |
"version": "4.0.0", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.