Skip to content

Conversation

dmitrykobets-msft
Copy link
Member

Update to latest GSL release 4.0.0

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout b41cc261730535f05cc1d0efbcaa821f2162f49e -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 0adcb2c..1646200 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -4569,7 +4569,7 @@
       "port-version": 1
     },
     "ms-gsl": {
-      "baseline": "3.1.0",
+      "baseline": "4.0.0",
       "port-version": 1
     },
     "ms-quic": {
diff --git a/versions/m-/ms-gsl.json b/versions/m-/ms-gsl.json
index a33d7ae..107d7f9 100644
--- a/versions/m-/ms-gsl.json
+++ b/versions/m-/ms-gsl.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "94671f83bf3c06bc9513f73efad3ae8636284ac3",
+      "version-string": "4.0.0",
+      "port-version": 1
+    },
     {
       "git-tree": "d51947d40835a72b1728c68ca8587e04e3f8e1e2",
       "version-string": "3.1.0",

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/ms-gsl/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/ms-gsl/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

@dmitrykobets-msft dmitrykobets-msft changed the title Bump GSL to 4.0.0 [ms-gsl] Bump GSL to 4.0.0 Jan 25, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout b41cc261730535f05cc1d0efbcaa821f2162f49e -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 0adcb2c..1646200 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -4569,7 +4569,7 @@
       "port-version": 1
     },
     "ms-gsl": {
-      "baseline": "3.1.0",
+      "baseline": "4.0.0",
       "port-version": 1
     },
     "ms-quic": {
diff --git a/versions/m-/ms-gsl.json b/versions/m-/ms-gsl.json
index a33d7ae..107d7f9 100644
--- a/versions/m-/ms-gsl.json
+++ b/versions/m-/ms-gsl.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "94671f83bf3c06bc9513f73efad3ae8636284ac3",
+      "version-string": "4.0.0",
+      "port-version": 1
+    },
     {
       "git-tree": "d51947d40835a72b1728c68ca8587e04e3f8e1e2",
       "version-string": "3.1.0",

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/ms-gsl/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/ms-gsl/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout b41cc261730535f05cc1d0efbcaa821f2162f49e -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/m-/ms-gsl.json b/versions/m-/ms-gsl.json
index 107d7f9..04814e0 100644
--- a/versions/m-/ms-gsl.json
+++ b/versions/m-/ms-gsl.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "94671f83bf3c06bc9513f73efad3ae8636284ac3",
+      "git-tree": "6868c861f4dc2e65f19b6c9ab6852c3d0e1c2c25",
       "version-string": "4.0.0",
       "port-version": 1
     },

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/ms-gsl/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout b41cc261730535f05cc1d0efbcaa821f2162f49e -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/m-/ms-gsl.json b/versions/m-/ms-gsl.json
index 107d7f9..dad94a9 100644
--- a/versions/m-/ms-gsl.json
+++ b/versions/m-/ms-gsl.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "94671f83bf3c06bc9513f73efad3ae8636284ac3",
+      "git-tree": "8e011584b29452a8cf665b1c50d53a986a74292f",
       "version-string": "4.0.0",
       "port-version": 1
     },

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/ms-gsl/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

@dmitrykobets-msft
Copy link
Member Author

It appears that the new version of GSL is causing breaking changes in some other vcpkg projects (coroutine, seal), which is causing the test failures; ms-gsl itself is building/installing fine. The breaking changes are expected. Is there a way to configure the broken projects to not automatically jump to the latest version of GSL? The project owners will need to manually resolve the build errors before they can upgrade to the latest version...

@JonLiu1993 JonLiu1993 self-assigned this Jan 26, 2022
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Jan 26, 2022
@JonLiu1993
Copy link
Contributor

It appears that the new version of GSL is causing breaking changes in some other vcpkg projects (coroutine, seal), which is causing the test failures; ms-gsl itself is building/installing fine. The breaking changes are expected. Is there a way to configure the broken projects to not automatically jump to the latest version of GSL? The project owners will need to manually resolve the build errors before they can upgrade to the latest version...

@dmitrykobets-msft ,CI will test all ports that depend on ms-gsl or ms-gsl. If it fails, we need to fix the problems of other ports together. Those dependencies can't be skipped to avoid problems.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout b41cc261730535f05cc1d0efbcaa821f2162f49e -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index e8c7779..495baeb 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -4574,7 +4574,7 @@
     },
     "ms-gsl": {
       "baseline": "4.0.0",
-      "port-version": 1
+      "port-version": 0
     },
     "ms-quic": {
       "baseline": "1.2.0",
diff --git a/versions/m-/ms-gsl.json b/versions/m-/ms-gsl.json
index 107d7f9..6a0370d 100644
--- a/versions/m-/ms-gsl.json
+++ b/versions/m-/ms-gsl.json
@@ -1,9 +1,9 @@
 {
   "versions": [
     {
-      "git-tree": "94671f83bf3c06bc9513f73efad3ae8636284ac3",
-      "version-string": "4.0.0",
-      "port-version": 1
+      "git-tree": "39bf0cb350976044ae5ced02bd6b8f02e0c8b1f3",
+      "version": "4.0.0",
+      "port-version": 0
     },
     {
       "git-tree": "d51947d40835a72b1728c68ca8587e04e3f8e1e2",

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/ms-gsl/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout b41cc261730535f05cc1d0efbcaa821f2162f49e -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index f793c1a..04e10b4 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -4574,7 +4574,7 @@
     },
     "ms-gsl": {
       "baseline": "4.0.0",
-      "port-version": 1
+      "port-version": 0
     },
     "ms-quic": {
       "baseline": "1.2.0",
diff --git a/versions/c-/coroutine.json b/versions/c-/coroutine.json
index 58c6b5b..9f4f390 100644
--- a/versions/c-/coroutine.json
+++ b/versions/c-/coroutine.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "54c52d6ddca16c077b47f703d30e912c8dd5b413",
+      "git-tree": "c1ce0f42bbf3898d3421a3c7b6494f69853385f5",
       "version": "1.5.0",
       "port-version": 4
     },
diff --git a/versions/m-/ms-gsl.json b/versions/m-/ms-gsl.json
index dad94a9..6a0370d 100644
--- a/versions/m-/ms-gsl.json
+++ b/versions/m-/ms-gsl.json
@@ -1,9 +1,9 @@
 {
   "versions": [
     {
-      "git-tree": "8e011584b29452a8cf665b1c50d53a986a74292f",
-      "version-string": "4.0.0",
-      "port-version": 1
+      "git-tree": "39bf0cb350976044ae5ced02bd6b8f02e0c8b1f3",
+      "version": "4.0.0",
+      "port-version": 0
     },
     {
       "git-tree": "d51947d40835a72b1728c68ca8587e04e3f8e1e2",

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/coroutine/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/coroutine/vcpkg.json
  • ports/ms-gsl/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout c76e5f092a3919edd52ea81e6c7a75af5cff7e39 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/c-/coroutine.json b/versions/c-/coroutine.json
index 58c6b5b..9f4f390 100644
--- a/versions/c-/coroutine.json
+++ b/versions/c-/coroutine.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "54c52d6ddca16c077b47f703d30e912c8dd5b413",
+      "git-tree": "c1ce0f42bbf3898d3421a3c7b6494f69853385f5",
       "version": "1.5.0",
       "port-version": 4
     },
diff --git a/versions/m-/ms-gsl.json b/versions/m-/ms-gsl.json
index 107d7f9..dad94a9 100644
--- a/versions/m-/ms-gsl.json
+++ b/versions/m-/ms-gsl.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "94671f83bf3c06bc9513f73efad3ae8636284ac3",
+      "git-tree": "8e011584b29452a8cf665b1c50d53a986a74292f",
       "version-string": "4.0.0",
       "port-version": 1
     },

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/coroutine/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/coroutine/vcpkg.json
  • ports/ms-gsl/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout c76e5f092a3919edd52ea81e6c7a75af5cff7e39 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/c-/coroutine.json b/versions/c-/coroutine.json
index 58c6b5b..9f4f390 100644
--- a/versions/c-/coroutine.json
+++ b/versions/c-/coroutine.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "54c52d6ddca16c077b47f703d30e912c8dd5b413",
+      "git-tree": "c1ce0f42bbf3898d3421a3c7b6494f69853385f5",
       "version": "1.5.0",
       "port-version": 4
     },
diff --git a/versions/m-/ms-gsl.json b/versions/m-/ms-gsl.json
index 107d7f9..dad94a9 100644
--- a/versions/m-/ms-gsl.json
+++ b/versions/m-/ms-gsl.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "94671f83bf3c06bc9513f73efad3ae8636284ac3",
+      "git-tree": "8e011584b29452a8cf665b1c50d53a986a74292f",
       "version-string": "4.0.0",
       "port-version": 1
     },

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/coroutine/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/coroutine/vcpkg.json
  • ports/ms-gsl/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout c76e5f092a3919edd52ea81e6c7a75af5cff7e39 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/c-/coroutine.json b/versions/c-/coroutine.json
index 58c6b5b..9f4f390 100644
--- a/versions/c-/coroutine.json
+++ b/versions/c-/coroutine.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "54c52d6ddca16c077b47f703d30e912c8dd5b413",
+      "git-tree": "c1ce0f42bbf3898d3421a3c7b6494f69853385f5",
       "version": "1.5.0",
       "port-version": 4
     },

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/coroutine/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/coroutine/vcpkg.json
  • ports/ms-gsl/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for coroutine but no changes to version or port version.
-- Version: 1.5.0#3
-- Old SHA: d6cef429d17c011260cd718a2738ec7282098866
-- New SHA: 54c52d6ddca16c077b47f703d30e912c8dd5b413
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout c76e5f092a3919edd52ea81e6c7a75af5cff7e39 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index fc7fa4d..3bf2ed4 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -4573,7 +4573,7 @@
       "port-version": 1
     },
     "ms-gsl": {
-      "baseline": "3.1.0",
+      "baseline": "4.0.0",
       "port-version": 1
     },
     "ms-quic": {
diff --git a/versions/m-/ms-gsl.json b/versions/m-/ms-gsl.json
index a33d7ae..dad94a9 100644
--- a/versions/m-/ms-gsl.json
+++ b/versions/m-/ms-gsl.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "8e011584b29452a8cf665b1c50d53a986a74292f",
+      "version-string": "4.0.0",
+      "port-version": 1
+    },
     {
       "git-tree": "d51947d40835a72b1728c68ca8587e04e3f8e1e2",
       "version-string": "3.1.0",

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/coroutine/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/ms-gsl/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout c76e5f092a3919edd52ea81e6c7a75af5cff7e39 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/m-/ms-gsl.json b/versions/m-/ms-gsl.json
index b387b77..dad94a9 100644
--- a/versions/m-/ms-gsl.json
+++ b/versions/m-/ms-gsl.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "6d7896bb36379ffa6821ab13f674da1685f42886",
+      "git-tree": "8e011584b29452a8cf665b1c50d53a986a74292f",
       "version-string": "4.0.0",
       "port-version": 1
     },

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/coroutine/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/coroutine/vcpkg.json
  • ports/ms-gsl/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout c76e5f092a3919edd52ea81e6c7a75af5cff7e39 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/c-/coroutine.json b/versions/c-/coroutine.json
index 14adbfd..9f4f390 100644
--- a/versions/c-/coroutine.json
+++ b/versions/c-/coroutine.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "563f4a3900b599145352f8517d9566358f51ceae",
+      "git-tree": "c1ce0f42bbf3898d3421a3c7b6494f69853385f5",
       "version": "1.5.0",
       "port-version": 4
     },
diff --git a/versions/m-/ms-gsl.json b/versions/m-/ms-gsl.json
index b387b77..dad94a9 100644
--- a/versions/m-/ms-gsl.json
+++ b/versions/m-/ms-gsl.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "6d7896bb36379ffa6821ab13f674da1685f42886",
+      "git-tree": "8e011584b29452a8cf665b1c50d53a986a74292f",
       "version-string": "4.0.0",
       "port-version": 1
     },

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/coroutine/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/coroutine/vcpkg.json
  • ports/ms-gsl/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/coroutine/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/coroutine/vcpkg.json
  • ports/ms-gsl/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/coroutine/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/coroutine/vcpkg.json
  • ports/ms-gsl/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 07e508359ca5488456988191d8709722484daccd -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/m-/ms-gsl.json b/versions/m-/ms-gsl.json
index 8fa4edd..e9ea842 100644
--- a/versions/m-/ms-gsl.json
+++ b/versions/m-/ms-gsl.json
@@ -5,11 +5,6 @@
       "version-string": "4.0.0",
       "port-version": 0
     },
-    {
-      "git-tree": "08f9b531d47ac5bc5bdf138b7f2d5f71af12e3f9",
-      "version-string": "4.0.0",
-      "port-version": 1
-    },
     {
       "git-tree": "d51947d40835a72b1728c68ca8587e04e3f8e1e2",
       "version-string": "3.1.0",

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/coroutine/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/coroutine/vcpkg.json
  • ports/ms-gsl/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/coroutine/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/coroutine/vcpkg.json
  • ports/ms-gsl/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

@dmitrykobets-msft
Copy link
Member Author

Hi @mathisloge, I can't figure out how to reply to your comment because github says it's outdated -- but I removed the port version number now. Thanks

"name": "ms-gsl",
"version-string": "3.1.0",
"port-version": 1,
"version-string": "4.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version-string": "4.0.0",
"version": "4.0.0",

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/coroutine/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/coroutine/vcpkg.json
  • ports/ms-gsl/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/coroutine/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/coroutine/vcpkg.json
  • ports/ms-gsl/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/coroutine/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/coroutine/vcpkg.json
  • ports/ms-gsl/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

@JonLiu1993
Copy link
Contributor

@dmitrykobets-msft ,Looks CI tested failed om x64-linux and x64-osx
This is error log, please take a look:

CMake Warning at /agent/_work/1/s/scripts/buildsystems/vcpkg.cmake:788 (_find_package):
  Could not find a configuration file for package "Microsoft.GSL" that is
  compatible with requested version "3".

  The following configuration files were considered but not accepted:

    /mnt/vcpkg-ci/installed/x64-linux/share/Microsoft.GSL/Microsoft.GSLConfig.cmake, version: 4.0.0

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/coroutine/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/coroutine/vcpkg.json
  • ports/ms-gsl/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 912bfa9d883cac8b06ae7dc797a6166df345d96d -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/s-/seal.json b/versions/s-/seal.json
index 066cf7f..4f98bed 100644
--- a/versions/s-/seal.json
+++ b/versions/s-/seal.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "1b6958c16374d8d8c431f89dfc671bd950b52ae3",
+      "git-tree": "11dc6c4e8b720416ff6ce195e48287982a6131ec",
       "version-semver": "3.7.2",
       "port-version": 1
     },

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/coroutine/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/coroutine/vcpkg.json
  • ports/ms-gsl/vcpkg.json
  • ports/seal/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/coroutine/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/coroutine/vcpkg.json
  • ports/ms-gsl/vcpkg.json
  • ports/seal/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

@ras0219-msft ras0219-msft merged commit aad1aa2 into microsoft:master Feb 1, 2022
@ras0219-msft
Copy link
Collaborator

LGTM, thanks for looking into the dependent conflicts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants