Bump cyclic dependencies and convert the decoupled-local-node-rig to use flat eslint config. #5271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclanton
requested review from
octogonz,
apostolisms,
D4N14L,
dmichon-msft and
patmill
as code owners
dmichon-msft
approved these changes
Jul 7, 2025
D4N14L
approved these changes
Jul 8, 2025
| @@ -78,8 +77,10 @@ ruleTester.run('no-external-local-imports', noExternalLocalImportsRule, { | |||
| code: "import blah from '../foo'", | |||
| errors: [{ messageId: 'error-external-local-imports' }], | |||
| filename: 'blah/test.ts', | |||
| parserOptions: { | |||
| tsconfigRootDir: 'blah' | |||
| languageOptions: { | |||
There was a problem hiding this comment.
Should we have a test that validates both properties are valid?
There was a problem hiding this comment.
This is just a change in the testing library.
...upled-local-node-rig/profiles/default/includes/eslint/flat/patch/modern-module-resolution.js
Show resolved
Hide resolved
...ed-local-node-rig/profiles/default/includes/eslint/flat/patch/custom-config-package-names.js
Show resolved
Hide resolved
iclanton
added a commit
to iclanton/rushstack
that referenced
this pull request
Jul 8, 2025
Merged
iclanton
added a commit
that referenced
this pull request
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.