Bump cyclic dependencies and convert the decoupled-local-node-rig to use flat eslint config. (#5271)

* Rush update.

* Bump cyclic dependencies.

* fixup! Rush update.

* Update decoupled-node-rig to use flat config.

* fixup! Rush update.

* fixup! Update decoupled-node-rig to use flat config.

* fixup! Rush update.

* fixup! Update decoupled-node-rig to use flat config.

* fixup! Update decoupled-node-rig to use flat config.

* Make eslint 9 the default version in heft-lint-plugin.

* fixup! Rush update.

* Fix lint issues.

* fixup! Rush update.

* Rush change

* fixup! Fix lint issues.

* fixup! Bump cyclic dependencies.

* fixup! Fix lint issues.

* fixup! Rush update.

Author: iclanton

apps/api-extractor/.eslintrc.js

@@ -0,0 +1,21 @@
+// Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT license.
+// See LICENSE in the project root for license information.
+
+const nodeTrustedToolProfile = require('decoupled-local-node-rig/profiles/default/includes/eslint/flat/profile/node-trusted-tool');
+const friendlyLocalsMixin = require('decoupled-local-node-rig/profiles/default/includes/eslint/flat/mixins/friendly-locals');
+
+module.exports = [
+  ...nodeTrustedToolProfile,
+  ...friendlyLocalsMixin,
+  {
+    files: ['**/*.ts', '**/*.tsx'],
+    languageOptions: {
+      parserOptions: {
+        tsconfigRootDir: __dirname
+      }
+    },
+    rules: {
+      'no-console': 'off'
+    }
+  }
+];

apps/api-extractor/eslint.config.js

@@ -52,12 +52,13 @@
     "typescript": "5.8.2"
   },
   "devDependencies": {
-    "decoupled-local-node-rig": "workspace:*",
-    "@rushstack/heft": "0.73.2",
+    "@rushstack/heft": "0.74.0",
     "@types/lodash": "4.14.116",
     "@types/minimatch": "3.0.5",
     "@types/resolve": "1.20.2",
     "@types/semver": "7.5.0",
+    "decoupled-local-node-rig": "workspace:*",
+    "eslint": "~9.25.1",
     "local-eslint-config": "workspace:*"
   }
 }

apps/api-extractor/package.json

@@ -17,7 +17,7 @@ export class TypeScriptInternals {
   public static getImmediateAliasedSymbol(symbol: ts.Symbol, typeChecker: ts.TypeChecker): ts.Symbol {
     // Compiler internal:
     // https://github.com/microsoft/TypeScript/blob/v3.2.2/src/compiler/checker.ts
-    return (typeChecker as any).getImmediateAliasedSymbol(symbol); // eslint-disable-line @typescript-eslint/no-explicit-any
+    return (typeChecker as any).getImmediateAliasedSymbol(symbol);
   }
 
   /**

apps/api-extractor/src/analyzer/TypeScriptInternals.ts

@@ -283,7 +283,6 @@ export class ApiReportGenerator {
     reportVariant: ApiReportVariant
   ): void {
     // Should we process this declaration at all?
-    // eslint-disable-next-line no-bitwise
     if (!ApiReportGenerator._shouldIncludeDeclaration(collector, astDeclaration, reportVariant)) {
       span.modification.skipAll();
       return;

apps/api-extractor/src/generators/ApiReportGenerator.ts

@@ -1,8 +1,6 @@
 // Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT license.
 // See LICENSE in the project root for license information.
 
-/* eslint-disable no-bitwise */
-
 import * as ts from 'typescript';
 import { FileSystem, type NewlineKind, InternalError } from '@rushstack/node-core-library';
 import { ReleaseTag } from '@microsoft/api-extractor-model';

apps/api-extractor/src/generators/DtsRollupGenerator.ts

@@ -0,0 +1,18 @@
+// Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT license.
+// See LICENSE in the project root for license information.
+
+const nodeTrustedToolProfile = require('decoupled-local-node-rig/profiles/default/includes/eslint/flat/profile/node-trusted-tool');
+const friendlyLocalsMixin = require('decoupled-local-node-rig/profiles/default/includes/eslint/flat/mixins/friendly-locals');
+
+module.exports = [
+  ...nodeTrustedToolProfile,
+  ...friendlyLocalsMixin,
+  {
+    files: ['**/*.ts', '**/*.tsx'],
+    languageOptions: {
+      parserOptions: {
+        tsconfigRootDir: __dirname
+      }
+    }
+  }
+];

apps/heft/.eslintrc.js

@@ -49,8 +49,9 @@
   },
   "devDependencies": {
     "@microsoft/api-extractor": "workspace:*",
-    "@rushstack/heft": "0.73.2",
+    "@rushstack/heft": "0.74.0",
     "@types/watchpack": "2.4.0",
-    "decoupled-local-node-rig": "workspace:*"
+    "decoupled-local-node-rig": "workspace:*",
+    "eslint": "~9.25.1"
   }
 }

apps/heft/eslint.config.js

@@ -45,7 +45,7 @@ export class StaticFileSystemAdapter implements FileSystemAdapter {
         callback(e, {} as fs.Stats);
         return;
       }
-      // eslint-disable-next-line @rushstack/no-new-null
+
       callback(null, result);
     });
   }) as FileSystemAdapter['lstat'];
@@ -115,10 +115,8 @@ export class StaticFileSystemAdapter implements FileSystemAdapter {
       // When "withFileTypes" is false or undefined, the callback is expected to return a string array.
       // Otherwise, we return a fs.Dirent array.
       if (options?.withFileTypes) {
-        // eslint-disable-next-line @rushstack/no-new-null
         (callback as ReaddirDirentCallback)(null, result as fs.Dirent[]);
       } else {
-        // eslint-disable-next-line @rushstack/no-new-null
         (callback as ReaddirStringCallback)(null, result as string[]);
       }
     });