[0.67] fix(cli): fix cache not being used when there are no dependencies #9549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR backports microsoft#9522 to 0.67. - Bug fix (non-breaking change which fixes an issue) This addresses a perf regression in autolinking when there are no dependencies to link. Resolves microsoft#9518 Instead of checking whether the dependencies cache is empty, check whether it was instantiated. | Before | After | | -: | -: | | 22488ms | 3561ms |
ghost
added
jonthysell
added
the
AutoMerge
|
Hello @jonthysell! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 hours, a condition that will be fulfilled in about 9 hours 49 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
tido64
approved these changes
Feb 15, 2022
Khalef1
approved these changes
Feb 15, 2022
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports #9522 to 0.67.
This addresses a perf regression in autolinking when there are no dependencies to link.
Resolves #9518
Instead of checking whether the dependencies cache is empty, check whether it was instantiated.
Microsoft Reviewers: Open in CodeFlow