fix(RNPM): fix rnpm-plugin-windows to work with react-native-cli #552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This PR is blocked on the following PRs in react-native: This PR is also blocked on the following issues in react-native: |
local-cli/rnpm/windows/package.json
Outdated
| { | ||
| "name": "rnpm-plugin-windows", | ||
| "version": "0.1.1", | ||
| "version": "0.2.0-rc.0", |
Contributor
Author
There was a problem hiding this comment.
Make sure we switch to an official release and publish on NPM.
…/windows/index RNPM has recently moved to react-native, and there have been a few changes to the core behavior. Making sure our plugin is compatible.
RNPM has been merged into react-native and is now the primary architecture for the react-native CLI. As such, we finally have support for things like `react-native windows` and `react-native run-windows`. These changes update the declarative syntax for RNPM plugins to match what is required for integration with react-native-cli.
This version of the RNPM plugin is only expected to work with react-native 0.31.0 and later, earlier versions of react-native (and react-native-windows) should be used in conjunction with the rnpm global CLI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RNPM has recently moved to react-native, and there have been a few changes to the core behavior. Making sure our plugin is compatible.