Fixes command validity check for local-cli. #9171
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to the RNPM integration, command names would match the second argument passed to the react-native-cli. Now the command names contain some usage information (such as non-flag CLI arguments). This commit splits the name of the commands and checks that against the second command line argument.
Contributor
Author
|
Note to test this out, you can try to run |
|
By analyzing the blame information on this pull request, we identified @grabbou and @janicduplessis to be potential reviewers. |
ghost
added
GH Review: review-needed
CLA Signed
Contributor
|
@facebook-github-bot shipit |
ghost
added
GH Review: accepted
Import Started
|
Thanks for importing. |
ghost
added
the
CLA Signed
ghost
added
the
CLA Signed
Contributor
|
bartolkaruza
pushed a commit
to immidi/react-native
that referenced
this pull request
Aug 3, 2016
Summary: Prior to the RNPM integration, command names would match the second argument passed to the react-native-cli. Now the command names contain some usage information (such as non-flag CLI arguments). This commit splits the name of the commands and checks that against the second command line argument. Closes facebook#9171 Differential Revision: D3661799 fbshipit-source-id: dc2aa9cd9e69dde3c5b877aeb77a17c4f6427075
grabbou
pushed a commit
that referenced
this pull request
Aug 5, 2016
Summary: Prior to the RNPM integration, command names would match the second argument passed to the react-native-cli. Now the command names contain some usage information (such as non-flag CLI arguments). This commit splits the name of the commands and checks that against the second command line argument. Closes #9171 Differential Revision: D3661799 fbshipit-source-id: dc2aa9cd9e69dde3c5b877aeb77a17c4f6427075
bubblesunyum
pushed a commit
to iodine/react-native
that referenced
this pull request
Aug 23, 2016
Summary: Prior to the RNPM integration, command names would match the second argument passed to the react-native-cli. Now the command names contain some usage information (such as non-flag CLI arguments). This commit splits the name of the commands and checks that against the second command line argument. Closes facebook#9171 Differential Revision: D3661799 fbshipit-source-id: dc2aa9cd9e69dde3c5b877aeb77a17c4f6427075
mpretty-cyro
pushed a commit
to HomePass/react-native
that referenced
this pull request
Aug 25, 2016
Summary: Prior to the RNPM integration, command names would match the second argument passed to the react-native-cli. Now the command names contain some usage information (such as non-flag CLI arguments). This commit splits the name of the commands and checks that against the second command line argument. Closes facebook#9171 Differential Revision: D3661799 fbshipit-source-id: dc2aa9cd9e69dde3c5b877aeb77a17c4f6427075
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
Summary: Prior to the RNPM integration, command names would match the second argument passed to the react-native-cli. Now the command names contain some usage information (such as non-flag CLI arguments). This commit splits the name of the commands and checks that against the second command line argument. Closes facebook/react-native#9171 Differential Revision: D3661799 fbshipit-source-id: dc2aa9cd9e69dde3c5b877aeb77a17c4f6427075
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to the RNPM integration, command names would match the second argument passed to the react-native-cli. Now the command names contain some usage information (such as non-flag CLI arguments). This commit splits the name of the commands and checks that against the second command line argument.