Remove timeout commands from TimeoutPoller on command completion. #1789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an alternative fix to the TimeoutPoller memory leak, caused by commands being retained in the poller until timeout even if the commands complete.
|
|
Contributor
|
closing as this is obsoleted by #1794 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative fix to the TimeoutPoller memory leak (Issue #1781), caused by commands being retained in the poller until timeout even if the commands complete.
Link to issue:
#1781
The idea here is simply to remove the command from the TimeoutPoller on command completion. This is an alternative solution to the following pull-request:
#1782
Note that the two requests are not in conflict with each other, and should be thread safe together. However, I think only one of them should be applied, as it will render the other redundant.