Skip to content

Conversation

@johnny-egeland
Copy link

The TimeoutPoller previously did not release completed commands, and retained the instance in the command array until the entire timeout period has elapsed. Then it would unnecessarily call interrupt() on the command, before removing it from the TimeoutPoller.

This had the side effect that object being added to the TimeoutPoller would not be Garbage Collected until after the entire timeout period. If the query timeout was sufficiently long, it could potentially result in out-of-memory exceptions when the frequency of queries is high. Managing this by reducing the query timeout becomes an unnecessary "tuning" problem, where you choose between memory usage and the possibility of cancelling fully working but long lasting queries.

This commit fixes this issue by removing completed commands from the TimeoutPoller regardless of being timed out or not. This insures the command instances can be garbage collected. The issue has been reported here:

#1781

@lilgreenbird
Copy link
Contributor

closing as this is obsoleted by #1794

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants