Support for memory access and disassembly #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewcrawley
approved these changes
May 27, 2019
andrewcrawley
left a comment
andrewcrawley
left a comment
There was a problem hiding this comment.
LGTM aside from one typo. Apologies for submitting this to the wrong repo initially!
This was referenced Jul 21, 2020
Trass3r
referenced
this pull request
in microsoft/MIEngine
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on Andrew's PR microsoft/vscode-debugadapter-node#212 I've created a new PR for the DAP repo (where the truth lives).
I've only changed the name of the
pointerLengthattribute of the process event topointerSizebecause the description was already talking about "size" and the Internet thinks that "pointer size" is more common than "pointer length".