Fix build scripts and add visionOS support #1279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple fixes:
- building on Apple Silicon Macs - remove the assumptions that the build machine is always x86_64
- fix badly broken build.sh for Mac, especially with getopts for options & params
- extend build-ios.sh to allow building for iOS-derived platforms like visionOS
The expected iOS build invocation is:
build-ios.sh [clean] [release|debug] ${ARCH} ${PLATFORM}
where
ARCH = arm64|arm64e|x86_64
PLATFORM = iphoneos|iphonesimulator|xros|xrsimulator
The verification pipeline uses older Xcode -Wno-unused-but-set-variable is unknown to older compilers, add -Wno-unknown-warning-option
Contributor
|
Could the vision OS support to moved to a dedicated script like build-visionos.sh? |
lalitb
approved these changes
May 29, 2024
Contributor
lalitb
left a comment
lalitb
left a comment
There was a problem hiding this comment.
LGTM. Thanks for improving the build script too.
swasti29
reviewed
May 29, 2024
swasti29
approved these changes
May 29, 2024
Contributor
swasti29
left a comment
swasti29
left a comment
There was a problem hiding this comment.
Just make sure to test for all architecture and platform: device, simulator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple fixes:
The expected iOS build invocation is:
build-ios.sh [clean] [release|debug] ${ARCH} ${PLATFORM} where
ARCH = arm64|arm64e|x86_64
PLATFORM = iphoneos|iphonesimulator|xros|xrsimulator