Skip to content

Conversation

@absaroj
Copy link
Contributor

@absaroj absaroj commented Jun 22, 2023

Public Swift Wrapper API should not be exposing any of the ObjC types to make sure clients are not dependent on ObjC, in case in future we want to bypass ObjC layer and access Cpp apis directly from swift (announced in wwdc23).

  • hiding all objc types behind swift and making calls go through swift
  • exposed objc types are done via a typealias
  • getters and setters are exposed using computed properties
  • all methods require objc types in params in swift wrappers are made private

data storage is happening still at the objc layer, but that can be brought back to swift layer later if required (when we plan to bypass objc) due to clients not having objc dependency.

@absaroj absaroj requested a review from eduardo-camacho June 22, 2023 23:50
@absaroj absaroj merged commit cc955ac into main Jun 23, 2023
@absaroj absaroj deleted the absaroj/no_objc_exposed branch June 23, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants