-
Notifications
You must be signed in to change notification settings - Fork 58
Hiding all ObjC types behind Swift wrappers #1176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hey are not exposed to the lcient
mannie
approved these changes
Jun 22, 2023
eduardo-camacho
approved these changes
Jun 23, 2023
lalitb
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public Swift Wrapper API should not be exposing any of the ObjC types to make sure clients are not dependent on ObjC, in case in future we want to bypass ObjC layer and access Cpp apis directly from swift (announced in wwdc23).
data storage is happening still at the objc layer, but that can be brought back to swift layer later if required (when we plan to bypass objc) due to clients not having objc dependency.