adding typealias file to stop importing the objcmodule in clients #1171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absaroj
requested review from
ThomsonTan,
bliptec,
kindbe,
lalitb,
maxgolov,
mkoscumb,
reyang and
sid-dahiya
as code owners
lalitb
added a commit
that referenced
this pull request
Jun 21, 2023
…ng swift package (#1166) * adding swift wrapper * moving files to sources * moving files to proper places * adding module for header expose and importing it in swift wrapper * correcting files for build errors and other changes * adding module for objc * swift build passing' * adding readme * changing the package name to 1dsswiftwrapper * changing target name * adding pr suggestions * adding build.sh changes * cmake list file changes * creating static lib * adding swift wrappers build and linking * adding more logic for building and producing sample app * adding code for swiftc invoking * adding comments * adding change to create the sample app * linking and includding modules in swiftc to build the sample exe: being created * adding comments * compiling all files frrom sample * removing extraline * correcting the output folder of swift build * correcting build output folder paths * adding typealias file to stop importing the objcmodule in clients (#1171) * adding typealias file to stop importing the objcmodule in clients * giving better names --------- Co-authored-by: Lalit Kumar Bhasin <[email protected]>
absaroj
added a commit
that referenced
this pull request
Jun 23, 2023
* adding swift wrapper * moving files to sources * moving files to proper places * adding module for header expose and importing it in swift wrapper * correcting files for build errors and other changes * adding module for objc * swift build passing' * adding readme * changing the package name to 1dsswiftwrapper * changing target name * adding pr suggestions * adding build.sh changes * cmake list file changes * creating static lib * adding swift wrappers build and linking * adding more logic for building and producing sample app * adding code for swiftc invoking * adding comments * adding change to create the sample app * linking and includding modules in swiftc to build the sample exe: being created * adding comments * compiling all files frrom sample * removing extraline * correcting the output folder of swift build * correcting build output folder paths * adding typealias file to stop importing the objcmodule in clients (#1171) * adding typealias file to stop importing the objcmodule in clients * giving better names * adding call to create logger * adding changes for framework include * adding fwks * linking libs and fwks * adding getter and setters for swift as computed properties * adding sample app changes * adding app changes * adding commondatacontext * swift build passing * correcting common context init * adding get set in event properties list * adding getter to eventprops * removing useless methods * adding getter and setter for eventprops * adding getter * fixing type bug * fixing main app issues * adding semantic context variable to the logger * modifying the access level for the objc types in swift to make sure they are not exposed to the lcient * adding default constructor * keeping main.swift clean ' * correcting comment * adding computed property for objc variable --------- Co-authored-by: Lalit Kumar Bhasin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.