Deprecate IFluidObject Module Augmentation #8299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthony-murphy
commented
Nov 16, 2021
| import { IProvideRuntimeFactory } from "./runtime"; | ||
| import { IProvideFluidTokenProvider } from "./tokenProvider"; | ||
|
|
||
| declare module "@fluidframework/core-interfaces" { |
There was a problem hiding this comment.
this was duplicated for some reason
github-actions
bot
requested review from
ChumpChief,
curtisman and
skylerjokiel
github-actions
bot
added
area: definitions
area: framework
ChumpChief
approved these changes
Nov 17, 2021
github-actions
bot
requested review from
ChumpChief
and removed request for
a team
sonalideshpandemsft
pushed a commit
that referenced
this pull request
May 16, 2023
…ct (#15570) This change removes three deprecated items: 1. "localHelp" event on IContainerRuntimeEvents (#15518 followup) 2. PureDataObject.getFluidObjectFromDirectory (#15530 followup) 3. IProvideContainerRuntime (#8299 followup) For the last one, I also remove the automatic registration of the container runtime in the BaseContainerRuntimeFactory's dependency container (this seems inappropriate to me anyway) and removed the property from `ContainerRuntime` as well. I've proactively removed usages of the property from the Loop app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change deprecates all the augmented properties on fluid objects and redirects uses to use the utility type FluidObject.
related #8077 #8073